-
Notifications
You must be signed in to change notification settings - Fork 24
Add uconvert
and chemistry example
#48
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
- Motive: for consistency with Unitful - Also, we make the first argument the symbolic quantity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove string method
0107272
to
6ac1e78
Compare
uconvert
and chemistry example
3361675
to
2680c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great work @gaurav-arya!!
[Diff since v0.7.3](v0.7.3...v0.7.4) **Merged pull requests:** - Add `uconvert` and chemistry example (#48) (@gaurav-arya) - Add `uconvert` method for `QuantityArray` (#61) (@MilesCranmer) - Deprecate `expand_units` -> `uexpand` (#62) (@MilesCranmer)
I was doing my chemistry homework using
DynamicQuantities.jl
, and thought it might make for a nice docs example! This is on top of #47, making the diff a bit noisier.Edit: This PR now also implements
uconvert
, see #48 (comment).