Implements two gas reports, one for unit tests, and another for prod tests #805
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #805 +/- ##
========================================
Coverage 98.13% 98.13%
========================================
Files 58 58
Lines 3919 3919
Branches 513 513
========================================
Hits 3846 3846
Misses 73 73 Continue to review full report at Codecov.
|
| @@ -306,6 +306,7 @@ module.exports = { | |||
| enabled: false, | |||
| showTimeSpent: true, | |||
| currency: 'USD', | |||
| maxMethodDiff: 25, // CI will fail if gas usage is > than this % | |||
There was a problem hiding this comment.
How can we override this failure if the expected gas usage is going to be more than 25% (something that can't be optimised for example the recent exchange updates for debt snapshot might increase it by more than 25% ?)
There was a problem hiding this comment.
I suggest that in those cases, the percentage is incremented in the PR, but it has to be done consciously, and that's the whole point. After merge, another PR could lower the percentage again.
I requested this feature in eth-gas-reporter: cgewecke/eth-gas-reporter#217
This produces a new gas report in the "Checks" section and causes CI to fail if a method call consumes more than 25% than it did before.
Note that the "prod gas report" will only be produced on commits to the develop branch.