Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Task/fp 1439 yearly site theme for texascale #490

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 16, 2022

Overview

Add get_url_match filter to render string that matches given pattern from current page URL.

This supports annual stylesheets for Texascale.

To Do
  • FP-1652do without for now
  • local testing & screenshots
  • remote testing & screenshots

Related

Changes

Testing

Prep

Local. Have two pages that use Texascale templates and each has a year in it's url, e.g.:

Remote. Use existing pages:

Steps

  1. Load a page with 2019 (or any year 2019—2029) in its slug/path.
  2. Verify the following <link> IS added to <head>:
    <link rel="stylesheet" href="texascale-org/css/build/site.2019.css" data-year_slug="2019">
    
    (No such file exists, intentionally. I will create the stylesheet in a future PR. For now, just making sure I can.)
  3. Load a page with 2018 (or any year earlier than 2019) in its slug/path.
  4. Verify the following <link> is NOT added to <head>:
    <link rel="stylesheet" href="texascale-org/css/build/site.2019.css" data-year_slug="2018">
    

Screenshots

✓ Local
2019 2018
Local 2019 Local 2018
… Remote
2019 2018

|

@wesleyboar wesleyboar added the paused Started but not actively in progress label May 17, 2022
@wesleyboar wesleyboar removed the paused Started but not actively in progress label Jun 30, 2022
@wesleyboar wesleyboar added the blocked Unable to continue work label Jun 30, 2022
wesleyboar added a commit that referenced this pull request Jul 1, 2022
* feat(submod): texascale, load annual stylesheets

For: https://jira.tacc.utexas.edu/browse/FP-1439
Mirrors: #490

* feat(settings): explicitely load new get_url_match

For: https://jira.tacc.utexas.edu/browse/FP-1439

* feat(submod): texascale, merged its PR #148

For: https://jira.tacc.utexas.edu/browse/FP-1439
Gets: TACC/Core-CMS-Resources#148
@wesleyboar wesleyboar added paused Started but not actively in progress and removed blocked Unable to continue work labels Sep 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
paused Started but not actively in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant