Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhance: use independent TACC System Monitor plugin #908

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 27, 2025

Overview

Related

Changes

Testing

Warning

On LCCF, built-in test instance was deleted upon upgrade.1

Or test manually on local machine…
  1. Have a pre-existing Core-CMS from main.
  2. Checkout this branch.
  3. Rebuild pre-existing CMS (to install plugin from new source):
    make stop && make build && make start
  4. Update database to use new plugin:
    docker exec -it core_cms python manage.py migrate
    Verify database state:
    docker exec -it core_cms_postgres psql -U postgresadmin -d taccsite -c "\dt *system_monitor*"
    • Check old table is absent.
      taccsite_system_monitor_taccsitesystemmonitor
    • Check new table is present.
      djangocms_tacc_system_monitor_taccsitesystemmonitor
  5. Add System Monitor plugin.
  6. Verify it works.
    You must view Published page (not in ?edit mode).

UI

Screenshot 2025-01-27 at 13 56 11

Notes

Example Usage:

Footnotes

  1. Negligible, because this would only happen to Frontera's homepage and I would notice it missing upon upgrade, because I check entire home page each time I upgrade Frontera.

@wesleyboar wesleyboar changed the title enhance: use official TACC System Monitor plugin enhance: use external TACC System Monitor plugin Jan 27, 2025
@wesleyboar wesleyboar marked this pull request as draft January 27, 2025 19:31
@wesleyboar wesleyboar marked this pull request as ready for review January 27, 2025 21:36
@wesleyboar wesleyboar added enhancement Improvements or additions to existing features dependencies Pull requests that update a dependency file labels Jan 27, 2025
@wesleyboar wesleyboar changed the title enhance: use external TACC System Monitor plugin enhance: use independent TACC System Monitor plugin Jan 27, 2025
@wesleyboar
Copy link
Member Author

@taoteg & @rstijerina,
This is now available on LCCF (Pre-Prod).1

Footnotes

  1. Won't show data on our VMs until /api/system-monitor/ lists Vista.

@wesleyboar
Copy link
Member Author

Vista shows on LCCF (Pre-Prod) now!

There is a caveat, so maybe migration does not handle "both cases normally".

_P.S. The caveat is negligible, given an old instance only exists on one other site that only I deploy changes on and test well when I do._
@rstijerina
Copy link
Member

This looks good, but looking at https://github.com/TACC/Core-CMS-Plugin-System-Monitor, it appears to have outdated choices. (e.g. stampede2). We'll need to update that. For an enhancement, any way we can make the choices based on https://tap.tacc.utexas.edu/status? This is our source of truth.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file enhancement Improvements or additions to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants