Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

enhance: DSAPP-57 limit height of c-app-card desc #405

Merged
merged 2 commits into from
Oct 10, 2024
Merged

enhance: DSAPP-57 limit height of c-app-card desc #405

merged 2 commits into from
Oct 10, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 10, 2024 •
edited
Loading

Overview

Limit height of c-app-card desc, so DSAPP-57 can be fixed.

Related

Changes

  • changed .c-app-card description to be truncated many lines

Testing

  1. Open http://localhost:3000/components/preview/c-app-card.
  2. Change any description to have 3 or more lines of text.
  3. Verify text is truncated (thus height is limited.)

UI

before after
before after

@github-actions github-actions bot added the enhancement Improvements or additions to existing features label Oct 10, 2024
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Oct 10, 2024
@wesleyboar wesleyboar mentioned this pull request Oct 10, 2024
Merged
1 task
@wesleyboar wesleyboar merged commit d5d676d into main Oct 10, 2024
2 checks passed
@wesleyboar wesleyboar deleted the enhance/DSAPP-57-limit-height-of-app-card-desc branch October 10, 2024 23:05
@wesleyboar wesleyboar restored the enhance/DSAPP-57-limit-height-of-app-card-desc branch October 10, 2024 23:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvements or additions to existing features minor A feature in backward-compatible manner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar