feat(affix): affix complete🎉 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duenyang
reviewed
Jul 10, 2024
src/affix/affix.tsx
Outdated
|
|
||
| static propsType = { | ||
| children: Object, | ||
| container: Object, |
There was a problem hiding this comment.
看类型应该是 [String, Function]
src/affix/affix.tsx
Outdated
| static defaultProps = { container: () => window, offsetBottom: 0, offsetTop: 0 }; | ||
|
|
||
| static propsType = { | ||
| children: Object, |
There was a problem hiding this comment.
类型应为[String, Number, Object, Function]
src/affix/affix.tsx
Outdated
| static propsType = { | ||
| children: Object, | ||
| container: Object, | ||
| content: Object, |
src/affix/affix.tsx
Outdated
Comment on lines
25
to
29
| innerOffsetTop = signal(0); | ||
|
|
||
| inneroffsetBottom = signal(0); | ||
|
|
||
| innerZIndex = signal(0); |
There was a problem hiding this comment.
这几个被signal的变量并没有在render中使用，直接改成普通变量应该可以实现，signal的话会带来不必要的性能损耗
src/affix/affix.tsx
Outdated
Comment on lines
35
to
39
| scrollContainer = createRef<ScrollContainerElement>(); | ||
|
|
||
| placeholderEL = createRef<HTMLElement>(); | ||
|
|
||
| ticking = createRef<boolean>(); |
There was a problem hiding this comment.
同上，确认下是否必须要使用ref，直接this.scrollContainer访问应该可以
|
需要处理下冲突 |
duenyang
reviewed
Jul 15, 2024
duenyang
approved these changes
Jul 16, 2024
This was referenced Oct 17, 2024
Closed
This was referenced Dec 16, 2024
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#32
💡 需求背景和解决方案
📝 更新日志
feat(affix): affix complete🎉
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单