[SNAP-1240] Snappy monitoring dashboard #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts into snappydashbord page
…trol connections to locator and connections to data servers
…etails if same member shuts down and joins cluster back.
- Moved/shifted below listed files to cluster/src/main/scala/org/apache/spark/ui package - SnappyDashboardPage.scala - SnappyDashboardTab.scala - SnappyStatsTab.scala - SnappyStatsPage.scala - SnappyContext and ToolsCallbackImpl are updated for initiating Dashboard UI Tab and Page in Spark UI. - Sync spark submodule
… for UP and DOWN members respectively.
- Add Member Type coloumn in members list which displays whether member is locator/lead/data server. - Remove Lead, Locator and Server Columns from members list. - Some code clean up.
- Suggestion: Rename column Size to In Memory Size. - Suggestion: Add column Total Size. - Suggestion: Rename column Type to Storage Model. - Suggestion: Add column Distribution Type to display whther table is Partitioned or Replicated tabele.
- Suggestion: Add Used and Total Memory columns in members list. - Suggestion: Display Memory size in B or MB or GB. - Suggestion: Rename column Name/Id to Member. - Some Clean up.
2. Syncing with spark for following changes: A. Adding New method for generating Spark UI page without page header text. B. Updating CSS: Cluster Normal status text color is changed to match color of Normal health logo.
2. Suggestion: Rename Servers to Data Servers in Cluster stats section. 3. Suggestion: Display Data Servers count in Cluster Stats section.
Conflicts: spark store
rishitesh
suggested changes
Dec 13, 2016
| import org.apache.spark.ui.JettyUtils._ | ||
|
|
||
| /** | ||
| * Created by skapse on 18/10/16. |
| private def updateUI(sc: SparkContext): Unit = { | ||
| ToolsCallbackInit.toolsCallback.updateUI(sc.ui) | ||
| } | ||
|
|
||
| private def invokeServices(sc: SparkContext): Unit = { | ||
| SnappyContext.getClusterMode(sc) match { | ||
| case SnappyEmbeddedMode(_, _) => |
There was a problem hiding this comment.
You should also think, how new pages can be made pluggable. If required propose a change request upstream Spark. So that we don't have keep everything in Spark.
| @@ -104,6 +114,51 @@ object SnappyTableStatsProviderService extends Logging { | |||
| delay, delay) | |||
| } | |||
|
|
|||
|
|
|||
| def getAggregatedMemberStatsOnDemand: Unit = { | |||
There was a problem hiding this comment.
This method should be inside a try.catch block. So that any exception won't show up.
| import org.apache.spark.{Logging, SparkContext} | ||
|
|
||
| object SnappyTableStatsProviderService extends Logging { | ||
|
|
||
| @volatile private var tableSizeInfo = Map[String, SnappyRegionStats]() | ||
| @volatile |
There was a problem hiding this comment.
Why volatile if only accessed by one thread ?
There was a problem hiding this comment.
Ok, there is a reader as well Ignore.
2. Feedback Comment: Add Try Catch Block around getAggregatedMemberStatsOnDemand call. 3. Precheckin Failure: Solved Precheckin failure at updateUI(sc) call in SnappyContext.
|
Run precheckin |
|
Run precheckin |
rishitesh
approved these changes
Dec 14, 2016
Conflicts: spark store
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
SnappyData Product Features :
Create a new Dashboard UI in Spark UI Application to summarise and display the overall SnappyData cluster Statistics.
Patch testing
ReleaseNotes.txt changes
(Does this change require an entry in ReleaseNotes.txt? If yes, has it been added to it?)
Other PRs