Core / Settings: Improved settings loading / saving and the integration #190
Conversation
Alf21
added
area/code
- Fixed settings not updating in certain stages - Improved settings handling - Added a main setting change event - Fixed dropdown auto select bug - Default settings will be overwritten without dialog when loading settings from a file
| public int MinPlayers { get; set; } = 2; // The minimum players required to start. | ||
|
|
||
| public int PreRoundTime { get; set; } = 20; // The amount of time allowed for preparation. | ||
|
|
||
| public int RoundTime { get; set; } = 300; // The amount of time allowed for the main round. | ||
|
|
||
| public int PostRoundTime { get; set; } = 10; // The amount of time before the next round starts. | ||
|
|
||
| public int KillTimeReward { get; set; } = 30; // The amount of extra time given to traitors for killing an innocent. |
There was a problem hiding this comment.
I know someone suggested this, but imo these comments are not needed. If the variable name is that bad that someone can't understand it, it should be changed.
There was a problem hiding this comment.
Kept this for e.g. upcoming attribute property support. Anyways, these comments doesn't hurt imo.
| DefaultWalkController.SetSprintEnabled(value); | ||
| } | ||
|
|
||
| namespace Topics |
There was a problem hiding this comment.
I've seen this namespace a few times, what is the goal of describing what should be underneath it? Topics seems pretty vague to me.
There was a problem hiding this comment.
While TTTReborn.Settings stores the settings stuff, TTTReborn.Settings.Topic holds the setting topics, so you don't have just json structure stuff inside the defeault settings namespace.
|
|
||
| settings.JsonType = settingsName; | ||
|
|
||
| FileSystem.Data.WriteAllText(path + fileName + SETTINGS_FILE_EXTENSION, GetJSON<T>(settings)); |
| @@ -163,7 +169,7 @@ public void OnConfirm(FileSelectionEntry fileSelectionEntry) | |||
| } | |||
| else | |||
| { | |||
| CreateTreeView(_currentFolderPath + fileSelectionEntry.FileNameLabel.Text); | |||
| CreateTreeView(CurrentFolderPath + fileSelectionEntry.FileNameLabel.Text); | |||
| }); | ||
| } | ||
|
|
||
| private void OnAgreeSaveAs(FileSelection fileSelection) |
There was a problem hiding this comment.
probably can just be SaveAs
| dialogBox.Display(); | ||
| } | ||
|
|
||
| private void OnAgreeLoadFrom(FileSelection fileSelection, PanelContent menuContent) |
FileSelectionhandlingAdded
Tooltipbasic UI component:TODO
Updated json structure (e.g. serversettings):
{ "Round": { "MinPlayers": 2, "PreRoundTime": 10, "RoundTime": 100, "PostRoundTime": 8, "KillTimeReward": 20 }, "Movement": { "IsSprintEnabled": true }, "General": { "Language": "en-US" }, "JsonType": "ServerSettings" }Fixed dropdown cut off as well (caused by overflow):
