Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

33 prepare for software release #36

Merged
merged 46 commits into from
Nov 3, 2023
Merged

33 prepare for software release #36

merged 46 commits into from
Nov 3, 2023

Conversation

rogerkuou
Copy link
Member

@rogerkuou rogerkuou commented Oct 23, 2023

  • Fix: rename points dimension to space
  • Tests
    • Tests for _io.py
  • Documentation
    • add logo
    • mkdoc rendering
    • Function Examples
    • Add tutorial
  • Add a pyproject.toml file
    • Update doc link
    • Update change log link
  • GitHub actions
    • Build
    • Doc deploy when merge to main
    • Test
  • Citations
    • cff
    • zenodo json
  • README
    • Update description
    • Installation example
    • Checklist Badge: OpenSSF Best Practices
    • Other badges:
      • Sonarcloud
  • Update author names:
    • .cff
    • pyproject.toml
    • zenodo.json

@rogerkuou rogerkuou linked an issue Oct 23, 2023 that may be closed by this pull request
11 tasks
@rogerkuou rogerkuou force-pushed the 33_software_release branch from 6d6bcdb to e368495 Compare October 23, 2023 14:33
@rogerkuou rogerkuou force-pushed the 33_software_release branch from e368495 to f8ba13b Compare October 23, 2023 14:36
@rogerkuou rogerkuou changed the title 33 software release 33 prepare for software release Oct 26, 2023
@rogerkuou rogerkuou force-pushed the 33_software_release branch 9 times, most recently from 6693321 to d2fc0fc Compare October 26, 2023 13:25
@rogerkuou
Copy link
Member Author

Hi @fnattino and @SarahAlidoost, thanks for the review! I made update accoding to your comments, below is a summary:

GH actions:

  • Added build tests in build.yml
  • Fixed dependency installation in build.yml. Now the package dependencies are not installed in build.yml. That is down in sonarcloud.yml
  • Add Doc build test in build.yml
  • I still did not run unit test in build.yml since I think it is already covered in sonacloud.yml
  • Added pipy.yml. It will be triggered by a release. I will keep Finish software release #37 open for now.

Docs

  • Added some mkdocs extensions and enabled the python syntax rendering
  • Add a WIP claim in the "common operations" Tab. Submitted an issue for future work.
  • Fixed type in CHANGELOG.md and updated links

Citation

  • Updated the DOI in README to 10.5281/zenodo.7717027, it refers to all versions now.
  • Updated zenodo name to .zenodo.json
  • Applied Sarah's suggestion on her name >_-

Could you please have another look?

@fnattino
Copy link
Contributor

fnattino commented Nov 1, 2023

Great @rogerkuou!

  • I still did not run unit test in build.yml since I think it is already covered in sonacloud.yml

The only difference is that build runs for a set of OSs and Python versions, while sonar cloud can run for a single OS and version. So if you would like to find issues with different setups, you can run tests (without coverage) in build as well.

The only missing thing, in case you want to add it, is the contributing instructions. But for the rest, looks very good to me!

@rogerkuou
Copy link
Member Author

. But for the rest, looks very good to me!

Ah thanks, I will apply both: 1) add a tests in build, and 2) add a contributing instruction

rogerkuou and others added 3 commits November 2, 2023 10:04
Co-authored-by: Francesco Nattino <49899980+fnattino@users.noreply.github.com>
@rogerkuou
Copy link
Member Author

Hi @fnattino, I added the tests to build.yml and also added Contribution doc (mainly adpated from the CGC package). Would you like to give another look?

Copy link
Contributor

@fnattino fnattino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! :)

Copy link
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerkuou thanks for addressing the comments. I added some suggestions/comments and approved this PR.

rogerkuou and others added 2 commits November 3, 2023 11:24
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

96.3% 96.3% Coverage
0.0% 0.0% Duplication

@rogerkuou rogerkuou merged commit c17d7f2 into main Nov 3, 2023
@rogerkuou rogerkuou deleted the 33_software_release branch December 13, 2024 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

software release
3 participants