-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
33 prepare for software release #36
Conversation
6d6bcdb
to
e368495
Compare
e368495
to
f8ba13b
Compare
6693321
to
d2fc0fc
Compare
Hi @fnattino and @SarahAlidoost, thanks for the review! I made update accoding to your comments, below is a summary: GH actions:
Docs
Citation
Could you please have another look? |
Great @rogerkuou!
The only difference is that build runs for a set of OSs and Python versions, while sonar cloud can run for a single OS and version. So if you would like to find issues with different setups, you can run tests (without coverage) in build as well. The only missing thing, in case you want to add it, is the contributing instructions. But for the rest, looks very good to me! |
Ah thanks, I will apply both: 1) add a tests in build, and 2) add a contributing instruction |
Co-authored-by: Francesco Nattino <49899980+fnattino@users.noreply.github.com>
Hi @fnattino, I added the tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogerkuou thanks for addressing the comments. I added some suggestions/comments and approved this PR.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! |
points
dimension tospace
pyproject.toml
file