Update CMakeLists.txt for macOS #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is achieved by updating the CMake set-up: - add find_package(XercesC ...) (can be installed via brew) - link the target, as specified by FindXercesC.cmake - decrease the C++ standard to 14 (This is required, as libxsd uses std::auto_ptr which was removed in C++17. Hence, stricter compilers (e.g. Apple Clang) refuse to compile)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
libxerces-cby employingfind_package(..), which works cross-platformlibxerces-c(e.g., either viaaptorbrew)C++14due to out-of-date bundledlibxsdstd::auto_ptr. However, this feature was removed in C++17. So, GNU GCC compiles code that is actually not compliant with the standard.What might be better? Compile
libxsdwith C++14 and the rest with C++17.However, my quick-win strategy for setting this up failed --> So, how much do we want this?