Skip to content

feat: add JXL thumbnail and animated APNG + WEBP support (port #344 and partially port #357) #549

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

CyanVoxel
Copy link
Member

This PR is a port of both #344 and #357 which previously targeted thumbnails/Alpha-v9.4 to main (aka v9.5x).

This adds thumbnail/preview support for JXL images (based on #344) and adds animated playback of APNG and WEBP images (based on #357)

Closes #333.

CyanVoxel and others added 2 commits October 17, 2024 15:49
Co-Authored-By: BPplays <58504799+bpplays@users.noreply.github.com>
Co-Authored-By: BPplays <58504799+bpplays@users.noreply.github.com>
@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience Priority: Low Doesn't require immediate attention labels Oct 19, 2024
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Oct 19, 2024
@CyanVoxel CyanVoxel added the Status: Review Needed A review of this is needed label Oct 19, 2024
@BPplays
Copy link
Contributor

BPplays commented Oct 20, 2024

@CyanVoxel

anim_image.save(
     image_bytes_io,
     "GIF",

doesn't this only convert animated images to GIFs before rendering? i specifically preferred webp in my PR because it's much higher quality.

see my new comment below

@BPplays
Copy link
Contributor

BPplays commented Oct 20, 2024

@CyanVoxel i changed #357 to be based on this and include all the things it did in the alpha-9.4 branch.
i just did it so it might need more testing. I've done more testing and it seems to be fine now.

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Nov 7, 2024
@CyanVoxel CyanVoxel merged commit f21d49d into main Nov 7, 2024
15 checks passed
@CyanVoxel CyanVoxel changed the title feat: add JXL thumbnail and animated APNG + WEBP support (port #344 and #357) feat: add JXL thumbnail and animated APNG + WEBP support (port #344 and partially port #357) Nov 8, 2024
@CyanVoxel CyanVoxel deleted the jxl-animated branch December 1, 2024 00:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Priority: Low Doesn't require immediate attention Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: jpeg xl support
2 participants