fix: use absolute ffprobe path on macos (Fix #511) #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
CyanVoxel
changed the title
Computerdores
approved these changes
Dec 9, 2024
DandyDev01
pushed a commit
to DandyDev01/TagStudio
that referenced
this pull request
Dec 13, 2024
…udioDev#629) * bump pyside version to 6.8.0.1 * fix: try for absolute ffprobe path on macos
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #557. This PR resolves #511 by attempting to find ffprobe through a list of commonly known absolute paths:
As this issue affects builds of TagStudio, I would recommend building via PyInstaller and launching via Finder or Spotlight - not the command line.
Tested on macOS Sequoia 15.1.1, M4 (ARM), FFmpeg installed via Homebrew.