Skip to content

fix: properly remove reference to previous library #769

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: properly remove reference to previous library #769

wants to merge 2 commits into from

Conversation

SkeleyM
Copy link
Contributor

@SkeleyM SkeleyM commented Feb 2, 2025

close #767

@SkeleyM SkeleyM marked this pull request as draft February 2, 2025 11:04
@SkeleyM
Copy link
Contributor Author

SkeleyM commented Feb 2, 2025

Tests are failing under the conditions that are present at program startup, i mean the "Library has no attribute 'Engine" which happens when trying to access anything whilst outside of a library. even running the test from the main branch as the first one just causes a crash for me. but then again most of my tests are failing due to the caching system
image

@CyanVoxel CyanVoxel added TagStudio: Library Relating to the TagStudio library system Priority: High An important issue requiring attention Type: Bug Something isn't working as intended labels Feb 2, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Feb 2, 2025
@CyanVoxel CyanVoxel mentioned this pull request Feb 4, 2025
Merged
@CyanVoxel CyanVoxel added Priority: Medium An issue that shouldn't be be saved for last and removed Priority: High An important issue requiring attention labels Feb 5, 2025
@CyanVoxel CyanVoxel removed this from the SQL Parity milestone Feb 5, 2025
@CyanVoxel CyanVoxel mentioned this pull request Feb 5, 2025
Open
3 tasks
@CyanVoxel
Copy link
Member

@SkeleyM Are you still interested in working on something like this or should we just go ahead and mark #767 as closed as of #787?

@CyanVoxel CyanVoxel moved this from 🚧 In progress to 🍀 Backlog in TagStudio Development Mar 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: Medium An issue that shouldn't be be saved for last TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
TagStudio Development
Status: 🍀 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Editing things from a closed library
2 participants
@SkeleyM @CyanVoxel