Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: maintain the form types when transforming with useTransform hook #889

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Balastrong
Copy link
Member

@Balastrong Balastrong commented Aug 7, 2024

Passing the values (fn and deps) to transform works fine, it's just useTransform not being able to infer the TFormData properly.

Copy link

nx-cloud bot commented Aug 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b5078ce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 7, 2024

commit: b5078ce

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@889

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@889

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@889

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@889

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@889

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@889

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@889

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@889

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@889

Open in Stackblitz

More templates

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.37%. Comparing base (5473bb8) to head (b5078ce).
Report is 81 commits behind head on main.

Files Patch % Lines
packages/react-form/src/useTransform.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #889       +/-   ##
===========================================
- Coverage   91.55%   43.37%   -48.19%     
===========================================
  Files          21       10       -11     
  Lines         900       83      -817     
  Branches      206       11      -195     
===========================================
- Hits          824       36      -788     
+ Misses         71       42       -29     
  Partials        5        5               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant