Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add isBlurred field state #938

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

Pascalmh
Copy link
Contributor

@Pascalmh Pascalmh commented Sep 5, 2024

closes #939

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for this!

Copy link

nx-cloud bot commented Sep 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 77aa3ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@938

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@938

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@938

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@938

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@938

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@938

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@938

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@938

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@938

commit: 77aa3ab

@crutchcorn crutchcorn merged commit 47b8ff7 into TanStack:main Sep 5, 2024
4 checks passed
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (5473bb8) to head (77aa3ab).
Report is 116 commits behind head on main.

Files with missing lines Patch % Lines
packages/form-core/src/FieldApi.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   91.55%   89.88%   -1.67%     
==========================================
  Files          21       26       +5     
  Lines         900      989      +89     
  Branches      206      233      +27     
==========================================
+ Hits          824      889      +65     
- Misses         71       94      +23     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isBlurred state check
2 participants