-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci(*): add husky + lint-staged + prettier to remove chance to meet test:format error #7123
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 48a1c82. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48a1c82:
|
758b3be
to
bbf0ad6
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #7123 +/- ##
==========================================
+ Coverage 41.42% 41.48% +0.05%
==========================================
Files 184 184
Lines 7331 7331
Branches 1531 1521 -10
==========================================
+ Hits 3037 3041 +4
- Misses 3889 3895 +6
+ Partials 405 395 -10 |
ce616bb
to
cb0b2f9
Compare
cb0b2f9
to
c2eb992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I've seen this in PRs lately and it drives me crazy. Why do people not run prettier in their editors locally on save. Beats me 🤷♂️
When I make Pull Request, Pretty frequently I encounter test:format error in ci.
So I think we should remove chance to meet this error by like below automatically by using husky + lint-staged + prettier