Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(solid-query): add optional chaining to prevent suspense bug #7709

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

dhruvy1
Copy link
Contributor

@dhruvy1 dhruvy1 commented Jul 10, 2024

This PR adds optional chaining to the Solid-Query examples to prevent a bug with suspense.
The fallback is always shown without this change.

Addresses #7507

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 10, 2024
@TkDodo TkDodo linked an issue Jul 17, 2024 that may be closed by this pull request
Copy link

nx-cloud bot commented Jul 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab75aed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: ab75aed

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7709

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7709

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7709

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7709

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7709

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7709

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7709

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7709

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7709

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7709

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7709

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7709

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7709

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7709

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7709

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7709

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7709

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7709

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7709

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7709

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7709


templates

@TkDodo TkDodo merged commit 91cfc10 into TanStack:main Jul 17, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solid-Query example returns repositoryQuery.data is undefined
2 participants