Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(svelte-query): Correct data type when initialData is set #7769

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jul 20, 2024

  • Adds more type tests from react-query, and fixed types for createQuery and createQueries
  • Some of these improvements came from fix(react-query): reorder query function declarations #7260
  • I removed an expect from a react-query type test, because it didn't actually have a value to expect, and already had an expectTypeOf check

@lachlancollins lachlancollins changed the title fix(svelte-query): Correct data type when initialData is set fix(svelte-query): Correct data type when initialData is set Jul 20, 2024
Copy link

nx-cloud bot commented Jul 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f1fb234. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: f1fb234

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7769

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7769

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7769

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7769

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7769

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7769

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7769

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7769

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7769

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7769

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7769

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7769

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7769

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7769

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7769

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7769

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7769

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7769

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7769

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7769

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7769


templates

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (e4e65be) to head (f1fb234).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7769       +/-   ##
===========================================
+ Coverage   44.64%   86.84%   +42.20%     
===========================================
  Files         185       42      -143     
  Lines        7078      479     -6599     
  Branches     1566      111     -1455     
===========================================
- Hits         3160      416     -2744     
+ Misses       3555       53     -3502     
+ Partials      363       10      -353     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 92.98% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query 87.33% <ø> (-2.67%) ⬇️
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit b764009 into main Jul 20, 2024
8 checks passed
@lachlancollins lachlancollins deleted the svelte-tests branch July 20, 2024 10:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant