-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/embeddings #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This commit refactors the monkey_patch module and persistence layer. The following files were modified:
Description:
Description:
Description: This commit updates the language modeler and embedding API in the monkey_patch package. The following files have been modified:
…ture Commit Description:
Description:
Commit Description: This commit fixes the load method in the `IBloomFilterPersistence` interface and the `FileSystemBloomFilterPersistence` class.
… files Commit description:
Description:
Description: This commit updates various files related to language models and embeddings. The following changes were made:
Description:
…ions with non-patched embeddable functions Commit Description:
Description:
Commit Description:
Commit Description:
Commit Description:
… from finetune hash
MartBakler
approved these changes
Nov 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to return embeddings for retrieval use-cases in the following syntax:
With alignment statements defining contrastive fine-tuning cases in the same syntax of existing align statements:
We are storing positive and negative contrastive examples, using the new Bloom filter implementation.
Because we can't use the patched embeddings to improve the quality of the model (AFAIK), we don't save them.
The new terminology for standard patches/align statements is
Symbolic
, and for embedding patches/align statements it isEmbeddable
.There is now an
EmbeddingModelManager
to handle the creation of prompts and to generate the embeddings.LanguageModeler
is now calledLanguageModelManager
and it is responsible for repairing and managing the operations of the backend LLM.High-level LLM providers can inherit from
Embedding_API
and/orLLM_API
to expose embedding and symbolic sampling support respectively.The next step is to move the low-level OpenAI finetuning logic into something like an
SymbolicFinetuningAPI
which handles training distilled models.Conversely, we could also create a
EmbeddingFinetuningAPI
to handle contrastive finetuning using the examples we are now collecting fromEmbedding
functions.Currently only OpenAI is supported - and it inherits from both
Embedding_API
andLLM_API
.