Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fixed lazy loading and sorting in AuthenticationLogsRelationManager #23

Conversation

carloeusebi
Copy link
Contributor

  • Eager loaded the authenticatable in the table query.
  • Moved the sorting from modifyQueryUsing to defaultSort, this fixed the issue where it was not possible to change the default order.

I would also argue that we could avoid showing and querying authenticatable as we are already in the authenticatable view and it is redundant information. But i will leave that decision to you.

@swilla swilla requested a review from andreia January 16, 2025 17:16
@andreia
Copy link
Member

andreia commented Jan 18, 2025

@carloeusebi Thank you for this contribution! :)

I agree that the authenticatable column can be removed from relation manager. Would you like to update this PR?

@carloeusebi
Copy link
Contributor Author

@andreia There you go!

You're welcome :)

@andreia
Copy link
Member

andreia commented Jan 19, 2025

@carloeusebi Thank you :)

@andreia andreia merged commit 6447a7c into TappNetwork:main Jan 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants