Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wip] Alternative API: allow to access DB explicitly #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kmike
Copy link
Contributor

@kmike kmike commented Mar 14, 2020

TODO:

  • DB object
  • allow to inject DB to callbacks
  • tests
  • docs
  • check if old Pythons need to be dropped

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #2 into master will decrease coverage by 6.84%.
The diff coverage is 84.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master       #2      +/-   ##
===========================================
- Coverage   100.00%   93.15%   -6.85%     
===========================================
  Files            2        3       +1     
  Lines           53       73      +20     
  Branches         5        5              
===========================================
+ Hits            53       68      +15     
- Misses           0        5       +5     
Impacted Files Coverage Δ
scrapy_crawl_once/db.py 80.00% <80.00%> (ø)
scrapy_crawl_once/__init__.py 100.00% <100.00%> (ø)
scrapy_crawl_once/middlewares.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b7b02...d2c3cd5. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants