Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[nightly] Downloader: audio stream selection does not work #10180

Closed
6 tasks done
TobiGr opened this issue Jun 22, 2023 · 0 comments · Fixed by #10230
Closed
6 tasks done

[nightly] Downloader: audio stream selection does not work #10180

TobiGr opened this issue Jun 22, 2023 · 0 comments · Fixed by #10230
Labels
bug Issue is related to a bug downloader Issue is related to the downloader

Comments

@TobiGr
Copy link
Contributor

TobiGr commented Jun 22, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.26.0 (nightly 55)

Steps to reproduce the bug

  1. Open a stream
  2. Click on "Download"
  3. Try to select a stream with a different file extension than the currently selected one.
  4. Hit "OK"

Expected behavior

Correct stream is downloaded

Actual behavior

The stream which is initially selected is downloaded, e.g. compare the file extensions or file sizes from the downloaded file with the selected stream.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

all

Affected device model

all

Additional information

This works in latest stable (0.25.1). I expect this to be a regression which was introduced by #9937.

@TobiGr TobiGr added bug Issue is related to a bug downloader Issue is related to the downloader labels Jun 22, 2023
@TobiGr TobiGr changed the title [nighlty] Downloader: stream selection does not work [nightly] Downloader: stream selection does not work Jun 26, 2023
@TobiGr TobiGr moved this to Todo in Before rewrite Jul 1, 2023
TobiGr added a commit that referenced this issue Jul 14, 2023
@TobiGr TobiGr changed the title [nightly] Downloader: stream selection does not work [nightly] Downloader: audio stream selection does not work Jul 14, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Before rewrite Jul 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant