-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Strange Playlist Order in the Add to Playlist preview #10993
Comments
I can't replicate this, but on a semi-related note, new playlists now go to the top. I like the sort option but I also liked it when they were put in alphabetical order when they were created. |
I know how to reproduce the bug. If you upgrade from 0.26.1 to 0.27.0 and then add a video to a playlist without rearranging a playlist first, the playlist will look messed up in the Add to Playlist Preview. However, if you rearrange a playlist, the preview will look the same as before. The issue can be closed. |
@Monstanner thank you for the details. Although this behavior is somewhat unintended, it's also something that can happen only right after upgrading to 0.27.0, so I wouldn't worry about it. It's ok that the order is not updated when querying playlists, but only when doing something with them. Anyway, this can be fixed by adding a clause to the ORDER BY of some SQL query, in case someone wants to solve it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Whilst that conclusion feels reasonable from the perspective of github folks and power users, I don't think it aligns very well with the reality of not-so-techy end users who appreciate NewPipe for their everyday yt endeavors and have learned how to use it, but e. g. wouldn't file bug reports - for the following reasons: 1. Who's affected: If this bug reproducibly shows up by the upgrade to 0.27.0, this means the entire userbase runs into it, with the exception of only those who don't upgrade to 0.27.0, or accidentally rearrange playlists before their next use of "add to playlist". 2. How severely affected: There are more severe bugs for sure, but if your collection of playlists has grown into the dozens, the messed-up order is a real nuisance every time you wish to playlist a new medium. 3. How easy to overcome: If you've never faced a need to rearrange playlists (because they've always been in consistent alphabetical order on their own), it's far from obvious how the sudden mess-up in the "add to playlist" dialog can be fixed.
Although I'm able to contribute to github issues (which already separates me from the majority of NewPipe users I know), I'm not a coder, hence left hoping for someone more technically adept to take care of the code side of things. Given the above reasons, would it be appropriate to reopen this issue, or am I totally off the road? |
It's also happening to me. It's annoying since the order of the playlists in the preview seems completely random, so one has to go through all the names to find the intended one... A big nuisance when adding many items to different playlists in a row. Edit: @Monstanner is right and after rearranging any one playlist the order gets fixed again. Thanks! |
Hello everybody! I am new to the open source community and I would like to contribute to NewPipe project. I had the same problem with the strange playlist order. It happens only when the user has not yet given an order to the playlists because at this phase the value displayIndex of each playlist (local or remote) is set to -1 and the code that create the list of playlist in "Bookmarked Playlists" sort every playlist with the same displayIndex value using a case insensitive order during the merge between remote and local playlists. While this case insensitive sorting does not happen for the add to playlist dialog list. We have some possible solutions that can be applied to fix the problem:
@Stypox what do you think about that ? In case you can assign this issue to me, thank you |
@nicholasala thank you for the interest! I would go with 1., which should be solvable by "adding a clause to the ORDER BY of some SQL query". I assigned the issue to you. |
Checklist
Affected version
0.27.0
Steps to reproduce the bug
Not really an issue
Expected behavior
The order of the playlist should be the same as in the previous versions (0.26.1, etc.)
Actual behavior
Wildly thrown together playlist order. (Only in the Add to Playlist preview)
Screenshots/Screen recordings
No response
Logs
No response
Affected Android/Custom ROM version
Android 13 Vanilla
Affected device model
Nokia X10
Additional information
No response
The text was updated successfully, but these errors were encountered: