JUnit 5 #768
Merged
JUnit 5 #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
litetex
commented
Dec 27, 2021
litetex
commented
- I carefully read the contribution guidelines and agree to them.
- This PR drops JUnit 4 and introduces the new and improved JUnit 5.
- Minor code reworks and fixes on the fly
Getting the initial page was not returning initial page
Stypox
requested changes
Jan 3, 2022
.../org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorDefaultTest.java
Show resolved
Hide resolved
...rc/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubePlaylistExtractorTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeMixPlaylistExtractorTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeMixPlaylistExtractorTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java
Outdated
Show resolved
Hide resolved
...va/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudSubscriptionExtractorTest.java
Show resolved
Hide resolved
...t/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudPlaylistExtractorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeChannelExtractorTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeAccountExtractorTest.java
Outdated
Show resolved
Hide resolved
...ava/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCConferenceListExtractorTest.java
Outdated
Show resolved
Hide resolved
* Deprecated Utils#UTF-8; see StandardCharsets * Added more helpful methods to ``ExtractorAsserts`` * Use parameterized (cool new) tests * Restore functionality of some tests + updated mockdata * Other code cleanups + Sonarlint improvements
TobiGr
reviewed
Jan 4, 2022
extractor/src/test/java/org/schabi/newpipe/extractor/ExtractorAsserts.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/utils/Utils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
|
@Stypox Ping |
Stypox
approved these changes
Jan 24, 2022
3 tasks
This was referenced Feb 11, 2022
This was referenced Mar 15, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.