Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

login stuff on frontent #102

Merged
merged 14 commits into from
Mar 11, 2023
Merged

login stuff on frontent #102

merged 14 commits into from
Mar 11, 2023

Conversation

grakkee
Copy link
Member

@grakkee grakkee commented Mar 8, 2023

This branch is untested, and still partially incomplete - just thought I would make this available for review before our demo.

@@ -17,13 +44,13 @@ export default defineComponent({
<v-card-title class="text-center">Login</v-card-title>
<v-card-text>
<v-form>
<v-text-field label="Username" solo />
<v-text-field type="password" label="Password" />
<v-text-field label="Username" solo @input="setUsername"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't v-model the idiomatic way of doing this?

@notgull notgull marked this pull request as ready for review March 9, 2023 03:29
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notgull notgull merged commit 6050a9a into master Mar 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants