[fix] 여행 목록 및 전체적인 버그 수정 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wjdtkdgns777
commented
Oct 6, 2024
•
wjdtkdgns777
commented
- 홈화면에서 여행 카테고리가 이제 서버에서 내려와 그걸로 수정해줬습니다
- 서버에 카테고리별로 요청보내게 수정되었습니다
- 여행목록에 여러 api 연결관련 버그를 수정했습니다
- 코끼리를 elerphant라고 써서 제대로 설명 표출이 안되던곳이 있는등의 휴먼에러를 발견하고 수정했습니다
- 디자인에 맞게 여행목록을 수정해주었습니다
easyhooon
reviewed
Oct 6, 2024
feature/trip-list/src/main/kotlin/com/tripmate/android/feature/trip_list/MateListScreen.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # feature/home/src/main/kotlin/com/tripmate/android/feature/home/HomeScreen.kt
easyhooon
reviewed
Oct 6, 2024
...rip-list/src/main/kotlin/com/tripmate/android/feature/trip_list/viewmodel/TripListUiState.kt
Outdated
Show resolved
Hide resolved
easyhooon
reviewed
Oct 6, 2024
...re/trip-list/src/main/kotlin/com/tripmate/android/feature/trip_list/component/MyTripStyle.kt
Outdated
Show resolved
Hide resolved
그밖에 피그마 디자인과 다른 부분 수정(색상, 단어 등등)
결과 화면이 뜨면 온보딩 종료되었다고 판단 -> 종료하고 앱에 재진입하면 홈 화면으로 이동 되도록
전체 화면 영역으로(statusbar) 백그라운드 색상이 적용되도록
easyhooon
added
feature
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.