Skip to content

fix(wp2static): Downloads WP2Static plugins from repo releases #58

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

nvnivs
Copy link
Collaborator

@nvnivs nvnivs commented Apr 25, 2022

Resolves #50

  • Downloads wp2static from repo releases
  • Downloads s3-addon from repo releases
  • Adds variables to control the versions of the plugins

@nvnivs nvnivs requested a review from petewilcock as a code owner April 25, 2022 10:08
@petewilcock
Copy link
Contributor

Looks really promising @z0c! Seems Github is having a blip with the tests, but I'll run the branch locally too for a test. Many thanks for the improvement! 👍

@nvnivs
Copy link
Collaborator Author

nvnivs commented Apr 25, 2022

thanks @petewilcock.

I suspect that some of the issues that actions is having is due to this being a branch of a branch on a fork, at least these type of errors:

error: pathspec 'wp2static_fix' did not match any file(s) known to git

@nvnivs
Copy link
Collaborator Author

nvnivs commented Apr 25, 2022

Also one thing i noticed, recently https://github.com/leonstafford/wp2static was migrated to https://github.com/WP2Static/wp2static

Not sure if the same is planned for https://github.com/leonstafford/wp2static-addon-s3, if it does the repo redirection should work on the curl command and get the archive downloaded.

@petewilcock petewilcock merged commit 2055ea5 into TechToSpeech:release/0.2.0 Apr 28, 2022
@nvnivs nvnivs deleted the wp2static_fix branch April 28, 2022 14:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants