Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use CompletableFutures for async update checking #1

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

TBlueF
Copy link
Contributor

@TBlueF TBlueF commented Oct 15, 2023

This PR removes the necessity of calling check() manually before logging the update-messages.
It also moves the async logic to a CompletableFuture to make sure that the actual check-call is only done once even if we call getLatestVersion() multiple times in quick succession. :)

@TBlueF
Copy link
Contributor Author

TBlueF commented Oct 15, 2023

Oh, i also removed the technicjelle.updatechecker.noasync option again, since it shouldn't be necessary anymore .. tell me if you still want to keep it ^^

@TechnicJelle TechnicJelle self-requested a review October 22, 2023 20:21
@TechnicJelle
Copy link
Owner

Do you think the readme also needs to be updated with mentions of these new additions?

@TechnicJelle TechnicJelle merged commit 8c5deed into TechnicJelle:main Nov 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants