Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix minor issues in devicelocation sample code #50

Merged
merged 11 commits into from
Dec 4, 2024
Merged

Fix minor issues in devicelocation sample code #50

merged 11 commits into from
Dec 4, 2024

Conversation

gitmai
Copy link
Collaborator

@gitmai gitmai commented Nov 28, 2024

No description provided.

@gitmai gitmai requested a review from diegotid November 28, 2024 16:21
diegotid
diegotid requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@diegotid diegotid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faltaría:

  • Segundo párrafo sobre llamar por HTTP y enlace a Postman
  • Falta todo el Frontend flow
  • Callout avisando que es sample code y hay cosas que cambiar
  • El most likely de usar el API desde backend es para SIM Swap, pero para Device Location no aplica, porque puede haber muchos casos de uso desde frontend
  • Falta la intro que va debajo del título "Authorization"
  • Faltan los tabs del resto de lenguajes en las cajas de código
  • Falta la intro que va debajo del título "API usage"

@diegotid diegotid requested a review from lufuOGW December 2, 2024 11:57
@gitmai gitmai requested a review from diegotid December 2, 2024 12:11
diegotid
diegotid requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@diegotid diegotid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the introduction paragraphs on each row, and wait por @lufuOGW approval (as original code contributor) to merge

And please, no PR without a description

catalog/devicelocation/samplecode_devicelocation.md Outdated Show resolved Hide resolved
catalog/devicelocation/samplecode_devicelocation.md Outdated Show resolved Hide resolved
@gitmai gitmai requested a review from diegotid December 2, 2024 14:50
diegotid
diegotid requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@diegotid diegotid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your texts!

Some rewording though

catalog/devicelocation/samplecode_devicelocation.md Outdated Show resolved Hide resolved
catalog/devicelocation/samplecode_devicelocation.md Outdated Show resolved Hide resolved
catalog/devicestatus/samplecode_devicestatus.md Outdated Show resolved Hide resolved
catalog/devicestatus/samplecode_devicestatus.md Outdated Show resolved Hide resolved
lufuOGW and others added 4 commits December 4, 2024 10:00
@lufuOGW @diegotid
Update catalog/devicestatus/samplecode_devicestatus.md
4cda658 
Co-authored-by: Diego Rivera <diego.rivera@telefonica.com>
@lufuOGW @diegotid
Update catalog/devicelocation/samplecode_devicelocation.md
a86bb19 
Co-authored-by: Diego Rivera <diego.rivera@telefonica.com>
@lufuOGW @diegotid
Update catalog/devicelocation/samplecode_devicelocation.md
da174d0 
Co-authored-by: Diego Rivera <diego.rivera@telefonica.com>
@lufuOGW @diegotid
Update catalog/devicestatus/samplecode_devicestatus.md
fd2b525 
Co-authored-by: Diego Rivera <diego.rivera@telefonica.com>
lufuOGW
lufuOGW approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@lufuOGW lufuOGW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes seem correct to me. Nice work!

diegotid
diegotid approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@diegotid diegotid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👏🏼

@gitmai gitmai self-assigned this Dec 4, 2024
@gitmai gitmai merged commit 866aae4 into main Dec 4, 2024
@gitmai gitmai deleted the refactor_dl_code branch December 4, 2024 09:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lufuOGW lufuOGW lufuOGW approved these changes

@diegotid diegotid diegotid approved these changes

Assignees

@gitmai gitmai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitmai @diegotid @lufuOGW