Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ImageViewer sfc to tsx,支持预加载,支持设置默认位置 #1422

Merged
merged 13 commits into from
Jun 7, 2024

Conversation

aaronmhl
Copy link
Contributor

@aaronmhl aaronmhl commented May 30, 2024

🤔 这个 PR 的性质是?

  • 新特性提交
    支持预加载
    支持设置默认位置
  • 重构
    ImageViewer sfc to tsx

🔗 相关 Issue

fix #1411

💡 需求背景和解决方案

📝 更新日志

  • feat(ImageViewer): sfctsx

  • feat(ImageViewer): 支持图片预加载和设置默认位置

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented May 30, 2024

完成

@anlyyao
Copy link
Collaborator

anlyyao commented Jun 6, 2024

  1. import props from './props'; 下面的 props: ImagediverProps,直接简写 props
  2. 流水线挂了,需要本地执行 npm run test:snap-update 更新快照,重新 push

@anlyyao
Copy link
Collaborator

anlyyao commented Jun 6, 2024

  1. import props from './props'; 下面的 props: ImagediverProps,直接简写 props
  2. 流水线挂了,需要本地执行 npm run test:snap-update 更新快照,重新 push
  3. 新增示例补充到 md文档,方便官网可以直接预览

@aaronmhl
Copy link
Contributor Author

aaronmhl commented Jun 6, 2024

  1. import props from './props'; 下面的 props: ImagediverProps,直接简写 props
  2. 流水线挂了,需要本地执行 npm run test:snap-update 更新快照,重新 push

已处理。

@LoopZhou
Copy link
Collaborator

LoopZhou commented Jun 6, 2024

drag getMaxDragY

这里的滚动区域top和bottom的配置是center的模式,是否应该要考虑一下长图align配置start或end时的滚动区域

@aaronmhl
Copy link
Contributor Author

aaronmhl commented Jun 6, 2024

  1. import props from './props'; 下面的 props: ImagediverProps,直接简写 props
  2. 流水线挂了,需要本地执行 npm run test:snap-update 更新快照,重新 push
  3. 新增示例补充到 md文档,方便官网可以直接预览

已处理。

@anlyyao anlyyao merged commit 9062b22 into Tencent:develop Jun 7, 2024
6 checks passed
@anlyyao
Copy link
Collaborator

anlyyao commented Jun 7, 2024

drag getMaxDragY
这里的滚动区域top和bottom的配置是center的模式,是否应该要考虑一下长图align配置start或end时的滚动区域

先合并当前版本,优化点另提 pr 处理~

@github-actions github-actions bot mentioned this pull request Jun 7, 2024
16 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageViewer
3 participants