perf: 任务列表响应速度优化 #7489 #7498
Merged
perf: 任务列表响应速度优化 #7489 #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
normal-wls
reviewed
Jun 24, 2024
| @@ -307,6 +311,13 @@ def list(self, request, *args, **kwargs): | |||
| ) | |||
|
|
|||
| page = list(queryset) | |||
| elif "no_pagination" in request.query_params: | |||
gcloud/apigw/views/utils.py
Outdated
| @@ -180,7 +180,10 @@ def paginate_list_data(request, queryset): | |||
| limit = int(request.GET.get("limit", 100)) | |||
| # limit 最大数量为200 | |||
| limit = 200 if limit > 200 else limit | |||
| count = queryset.count() | |||
| if request.GET.get("no_pagination"): | |||
gcloud/apigw/views/utils.py
Outdated
| @@ -180,7 +180,10 @@ def paginate_list_data(request, queryset): | |||
| limit = int(request.GET.get("limit", 100)) | |||
| # limit 最大数量为200 | |||
| limit = 200 if limit > 200 else limit | |||
| count = queryset.count() | |||
| if request.GET.get("no_pagination"): | |||
There was a problem hiding this comment.
get_task_list apigw api 文档说明
docs/apidoc/zh_hans/get_task_list.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| | expected_timezone | string | 否 | 任务时间相关字段期望返回的时区，形如Asia/Shanghai | | |||
| | limit | int | 否 | 分页，返回任务列表任务数，默认为100 | | |||
| | offset | int | 否 | 分页，返回任务列表起始任务下标，默认为0 | | |||
| | without_count | bool | 否 | 有无count，默认有 | | |||
There was a problem hiding this comment.
without_count=false 会有问题，【默认有】改成【默认返回 count 信息】
gcloud/apigw/views/utils.py
Outdated
| @@ -180,7 +180,10 @@ def paginate_list_data(request, queryset): | |||
| limit = int(request.GET.get("limit", 100)) | |||
| # limit 最大数量为200 | |||
| limit = 200 if limit > 200 else limit | |||
| count = queryset.count() | |||
| if request.GET.get("without_count"): | |||
There was a problem hiding this comment.
建议添加一个参数，without_count=False
normal-wls
approved these changes
Jun 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.