Added ObjectExtensions tests #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teodor92
requested changes
Oct 18, 2016
| using MoreDotNet.Extensions.Common; | ||
| using Xunit; | ||
|
|
||
| public class TypeCastTests |
There was a problem hiding this comment.
Please rename the test class to AsTests to reflect the method tested.
| } | ||
|
|
||
| [Fact] | ||
| public void ToDictionary_Null_ShouldThrowArgumentNullException() |
There was a problem hiding this comment.
Please move all Test related to ToDictionary to separate class.
| using MoreDotNet.Extensions.Common; | ||
| using Xunit; | ||
|
|
||
| public class TypeCheckTests |
There was a problem hiding this comment.
Please rename the test class to IsTests to reflect the method tested.
| } | ||
|
|
||
| [Fact] | ||
| public void IsNot_NullItem_ShouldThrowShouldThrowArgumentNullException() |
There was a problem hiding this comment.
Please move the IsNot tests to a separate class.
|
|
||
| [Fact] | ||
| public void Is_BIsNotA_ShouldReturnTrue() | ||
| { |
There was a problem hiding this comment.
Please rename to IsNot_BIsNotA_ShouldReturnTrue to reflect the method tested.
|
|
||
| [Fact] | ||
| public void Is_BIsNotB_ShouldReturnFalse() | ||
| { |
|
Hope i fixed everything with this commit :) |
Teodor92
approved these changes
Oct 19, 2016
|
Merged! Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for ObjectExtensions