Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use correct dot product for two vectors. #8

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

cgyurgyik
Copy link
Contributor

Fix error in Dot().

Fix error in Dot().
@restyled-io restyled-io bot mentioned this pull request Sep 2, 2020
@cgyurgyik cgyurgyik changed the title Update Vector.hpp Use correct dot product for two vectors. Sep 2, 2020
@TerensTare
Copy link
Owner

Thanks for noticing that. I never used it anywhere, so it was a tough one to find. I will merge immediately.

@TerensTare TerensTare merged commit cfe91d3 into TerensTare:master Sep 3, 2020
@cgyurgyik
Copy link
Contributor Author

No problem! Another thing to note is that inline constexpr for a function is redundant since C++17.
Reference: https://en.cppreference.com/w/cpp/language/constexpr

Either way, cool work so far. I would like to contribute more, but probably won't have much time with the school year starting.

@cgyurgyik cgyurgyik deleted the patch-1 branch September 3, 2020 15:25
@TerensTare
Copy link
Owner

TerensTare commented Sep 3, 2020

Yes I know about the redundant inline-s, it's just that I learned it after I wrote those functions and it is like a practice to me now. I am working on a new update, and I guess it's time for a contributors section in the readme. I will add your name on the top of the list.

I would like to contribute more, but probably won't have much time with the school year starting.

I guess it will affect me too, but here school will start in November.
Thanks for all, seriously.

@TerensTare TerensTare self-assigned this Sep 4, 2020
@TerensTare TerensTare added bug Something isn't working good first issue Good for newcomers labels Sep 4, 2020
@TerensTare TerensTare added this to the Release 1.0 milestone Sep 4, 2020
@TerensTare TerensTare modified the milestones: Release 1.0, Release 0.1 Sep 4, 2020
Copy link
Owner

@TerensTare TerensTare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good.

@cgyurgyik
Copy link
Contributor Author

Great! See you on the other side of the school semester.

@TerensTare
Copy link
Owner

I will be there.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants