Fix long-standing issue of plugin affecting the undo stack #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sublimehq/sublime_text#5842 This essentially replaces the `sublime.TextCommand`s with `WindowCommands`, which preserves the undo stack and no longer forces you to undo every character individually (i.e. restores sublime behavior) Additionally I moved the `ClearDecorations` to the `ClearCommand` since it was not called in the normal command anymore.
|
Fixes #37 |
|
Thank you! |
|
You're welcome! Do you know how long it takes for this update to show in package control? |
|
Next few hours now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sublimehq/sublime_text#5842
This essentially replaces the
sublime.TextCommands withWindowCommands, which preserves the undo stack and no longer forces you to undo every character individually (i.e. restores sublime behavior)Additionally I moved the
ClearDecorationsto theClearCommandsince it was not called in the normal command anymore.