Add flags to disable video recording and performance metrics #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It'd be awesome if you could update the release notes for this feature: |
| @@ -37,6 +38,7 @@ public void runGcloud(String testCase, String bucket, int shardIndex) | |||
| "instrumentation", | |||
| orchestratorFlag(), | |||
| autoGoogleLoginFlag(), | |||
| recordVideoFlag(), | |||
There was a problem hiding this comment.
performanceMetricsFlag() isn't used?
| } | ||
|
|
||
| public void setRecordVideo(boolean shouldRecordVideo) { | ||
| recordVideo = shouldRecordVideo; |
There was a problem hiding this comment.
the pattern seems to be:
this.recordVideo = recordVideo
It'd be nice to keep the code style consistent.
|
One small comment, otherwise looks good. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.