Tests implemented for each TestSmell (production file specified only …

…when required). IgnoredTest results in false positive; ConstructorInitialization and GeneralFixture are not detected.

src/main/java/edu/rit/se/testsmells/testsmell/AbstractSmell.java

@@ -4,20 +4,27 @@
 import com.github.javaparser.ast.body.MethodDeclaration;
 
 import java.io.FileNotFoundException;
-import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 public abstract class AbstractSmell {
     private final MethodValidator methodValidator;
     private final List<SmellyElement> smellyElementList;
 
     public abstract String getSmellName();
 
-    public abstract void runAnalysis(CompilationUnit testFileCompilationUnit, CompilationUnit productionFileCompilationUnit, String testFileName, String productionFileName) throws FileNotFoundException;
-
     public AbstractSmell() {
         methodValidator = new MethodValidator(); //TODO: dependency should be injected (or, at least, be a singleton)
-        smellyElementList = new ArrayList<>();
+        smellyElementList = new CopyOnWriteArrayList<>();
+    }
+
+    public abstract void runAnalysis(CompilationUnit testFileCompilationUnit, CompilationUnit productionFileCompilationUnit, String testFileName, String productionFileName) throws FileNotFoundException;
+
+    public void clear() {
+        for (SmellyElement smellyElement : smellyElementList) {
+            smellyElement.clear();
+        }
+        smellyElementList.clear();
     }
 
     /**

src/main/java/edu/rit/se/testsmells/testsmell/SmellsContainer.java

@@ -1,12 +1,12 @@
 package edu.rit.se.testsmells.testsmell;
 
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 public interface SmellsContainer {
-    List<AbstractSmell> testSmells = new ArrayList<>();
+    List<AbstractSmell> testSmells = new CopyOnWriteArrayList<>();
 
     Map<String, String> getTestDescriptionEntries();
 

src/main/java/edu/rit/se/testsmells/testsmell/SmellyElement.java

@@ -13,6 +13,10 @@ public SmellyElement(String name) {
         this.name = name;
     }
 
+    public void clear() {
+        data.clear();
+    }
+
     public void setHasSmell(boolean hasSmell) {
         this.hasSmell = hasSmell;
     }

src/main/java/edu/rit/se/testsmells/testsmell/TestSmellDetector.java

@@ -10,23 +10,40 @@
 import java.io.InputStream;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 public class TestSmellDetector {
 
+    private List<InputStream> inputStreams;
     private List<AbstractSmell> testSmells;
 
     /**
      * Instantiates the various test smell analyzer classes and loads the objects into an List
      */
     public TestSmellDetector() {
         testSmells = new ArrayList<>();
+        inputStreams = new ArrayList<>();
     }
 
     public void addDetectableSmell(AbstractSmell smell) {
         testSmells.add(smell);
     }
 
+    public void clear() {
+        for (InputStream inputStream : inputStreams) {
+            try {
+                inputStream.close();
+            } catch (IOException e) {
+                e.printStackTrace();
+            }
+        }
+        for (AbstractSmell smell : testSmells) {
+            smell.clear();
+        }
+        testSmells.clear();
+    }
+
     /**
      * Factory method that provides a new instance of the TestSmellDetector
      *
@@ -48,7 +65,7 @@ public List<String> getTestSmellNames() {
     /**
      * Loads the java source code file into an AST and then analyzes it for the existence of the different types of test smells
      */
-    public void detectSmells(TestFile testFile) {
+    public void detectSmells(TestFile testFile) throws IOException {
         CompilationUnit testFileCompilationUnit = parseIntoCompilationUnit(testFile.getTestFilePath());
 
         CompilationUnit productionFileCompilationUnit = parseIntoCompilationUnit(testFile.getProductionFilePath());
@@ -58,7 +75,7 @@ public void detectSmells(TestFile testFile) {
                 smell.runAnalysis(testFileCompilationUnit, productionFileCompilationUnit, testFile.getTestFileNameWithoutExtension(), testFile.getProductionFileNameWithoutExtension());
             } catch (FileNotFoundException ignored) {
             }
-            
+
             testFile.addDetectedSmell(smell);
             for (SmellsContainer element : smell.getSmellyElements()) {
                 element.addDetectedSmell(smell);
@@ -71,12 +88,15 @@ private CompilationUnit parseIntoCompilationUnit(String filePath) {
         if (StringUtils.isEmpty(filePath)) {
             return null;
         }
-        InputStream testFileInputStream;
+        InputStream testFileInputStream = null;
         try {
             testFileInputStream = new FileInputStream(filePath);
         } catch (IOException e) {
             testFileInputStream = getClass().getResourceAsStream(filePath);
+        } finally {
+            inputStreams.add(testFileInputStream);
         }
+        assert Objects.nonNull(testFileInputStream);
         return JavaParser.parse(testFileInputStream);
     }
 }