-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adds missing prop to __slots__
of Emoji
#1364
Conversation
Good catch. Yes, please add the missing slots. |
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 70 70
Lines 6657 6657
=======================================
Hits 6643 6643
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I am using `[]` for consistency with other `__slots__` definitions
Whitespace issues are the worst! 😒 |
This looks like a bug in
In the meantime, what should I do?
|
Ah, it's complaining about the empty slots? If an empty tuple works, may as well go with that... |
Thanks. |
Refs python/mypy#10864
Type of changes
Checklist
Description
This prop was missing from
__slots__
🙂There's one more thing: current
__slots__
setup does not work:This happens due to the fact that
JupiterMixin
does not have__slots__ = ()
defined.I can add it if you wish 🙂