Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Various docstring fixes, removing unused variables #3191

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

darrenburns
Copy link
Member

I found a bunch of issues with docstrings/unused variables during my time on #3180.
I gathered all of the diffs into this PR to keep #3180 focused.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aabfd16) 98.30% compared to head (cb211d5) 98.28%.
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3191      +/-   ##
==========================================
- Coverage   98.30%   98.28%   -0.03%     
==========================================
  Files          74       74              
  Lines        8038     8043       +5     
==========================================
+ Hits         7902     7905       +3     
- Misses        136      138       +2     
Flag Coverage Δ
unittests 98.28% <92.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rich/align.py 100.00% <ø> (ø)
rich/console.py 98.04% <100.00%> (+<0.01%) ⬆️
rich/containers.py 100.00% <ø> (ø)
rich/markdown.py 99.45% <100.00%> (ø)
rich/markup.py 100.00% <ø> (ø)
rich/progress.py 92.92% <ø> (ø)
rich/syntax.py 98.19% <100.00%> (-0.29%) ⬇️
rich/text.py 99.00% <66.66%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmcgugan willmcgugan merged commit 9f620dc into master Nov 7, 2023
@willmcgugan willmcgugan deleted the assorted-docs-and-tidying branch November 7, 2023 16:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants