Stop rich.live
from importing same module under a different name
#912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Rich instead of importing from the top-level package using the module name alone, uses module name with
__init__
which makes it get imported twice (under names:rich
andrich.__init__
).Minimal reproduction:
I found out about it because mypy is complaining about it just because I use rich in my project. However, even if you skip that, this could still possibly lead to some strange issues when depending on the fact that modules in Python are singletons.