MarkdownViewer link click behaviour

[lowekoz]

Running examples\markdown.py and clicking the example.md from the demo app will also open the relative file link ./example.md in the browser, which is a bit wonky behaviour. Relates to #5171 #5169, suggested fix by separating behaviour of external link protocols (http://,https://,ftp://...) and local resource path/anchor. With fix links won't trigger the browser open_url command, only external links will (if open_links=True), and external links won't trigger local navigation changes.

On approval TODOs:

• Docstrings on all new or modified functions / classes
• Updated documentation(x)
• Updated CHANGELOG.md (where appropriate)
• Tests (?)

[lowekoz]

cut.mp4

[lowekoz]

Our previous discussion on discord about the Markdown click behaviour revealed that there was a lot more detail to the matter than I expected. I am still determined to try contribute with a little something. I have therefore decided to limit the scope of this PR to primarily target the _markdown/MarkdownViewer class (not the Markdown class).

The Problem:

When a relative link is clicked in MarkdownViewer, the link also opens in the browser apart from in the viewer (see video above). One can fix this by setting open_links=False. However, doing so makes it no longer possible to open links that are clearly referencing an external resource (e.g. https://github.com). In addition, the MarkdownViewer does not seem to nativly support external links (crashes as it tries to read the link from disk)

The Fix:

I still think that the url.parse has potential use case here as default behaviour as per the previous commit but only for the MarkdownViewer. I fail to see where this might be problematic, what are your thoughts on this @willmcgugan ?

[lowekoz]

A display of the problem without current fix (MarkdownViewer crashes on external link pressed)

wofix.mp4

[JonathanPlasse]

Is there anything blocking this?