fix: fix alignment with auto and min height/width #5612
+274
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with alignment in containers with auto _and_ min height/width. Currently the size of the parent passed to `_align_size` doesn't account for any min height/width when the container has auto dimensions. Fixes Textualize#5608
|
I confess I don't fully understand all the inner workings of sizing and alignment in Textual, so there might be a better way of fixing this. All the tests seem to pass1 after this change so hopefully I'm on the right track, but I'd appreciate any feedback. Footnotes
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with alignment in containers with auto and min height/width. Currently the size of the parent passed to
_align_sizedoesn't account for any min height/width when the container has auto dimensions.Fixes #5608
Please review the following checklist.