Skip to content

Update jsoncons trait #375

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update jsoncons trait #375

wants to merge 7 commits into from

Conversation

dmazzella
Copy link

@dmazzella dmazzella commented Mar 22, 2025 •
edited by prince-chrismc
Loading

a try to solve #371

Closes #371

@dmazzella
Copy link
Author

@prince-chrismc can please do a review?

@dmazzella dmazzella changed the title Update traits.h Update jsoncons trait Mar 23, 2025
prince-chrismc
prince-chrismc reviewed Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions but looks really promising

@prince-chrismc
Copy link
Collaborator

Seems a type is wrong with the object subscription https://github.com/Thalhammer/jwt-cpp/actions/runs/14010395755/job/39397134923?pr=375#step:11:1748

@dmazzella
Copy link
Author

@prince-chrismc @Thalhammer can you take a look at it?

@prince-chrismc
Copy link
Collaborator

prince-chrismc commented Apr 14, 2025 •
edited
Loading

This is a break but only for this implementation that has a different major. I think the changes to the example are acceptable

@prince-chrismc
Copy link
Collaborator

prince-chrismc commented Apr 14, 2025 •
edited
Loading

Cmake v4 is not compatible. I'll make some time for this

@dmazzella
Copy link
Author

Cmake v4 is not compatible. I'll make some time for this

this is outside the scope of my PR

@dmazzella dmazzella changed the title Update jsoncons trait Update jsoncons trait and update nlohmann-json to 3.12.0 Apr 18, 2025
@dmazzella
Copy link
Author

Cmake v4 is not compatible. I'll make some time for this

with latest commit I tried to fix cmake min requirements for nlohmann-json

@prince-chrismc
Copy link
Collaborator

@dmazzella can you revert the changes for nlohmann-json please.

I will merge the other PR and then this one

@dmazzella dmazzella changed the title Update jsoncons trait and update nlohmann-json to 3.12.0 Update jsoncons trait Apr 23, 2025
@dmazzella dmazzella mentioned this pull request Apr 23, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsoncons trait longer compatible with latest release
2 participants
@dmazzella @prince-chrismc