-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DATA: EventsV2 #144
base: main
Are you sure you want to change the base?
DATA: EventsV2 #144
Conversation
[YamlMember(Alias = "pull_request", DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | ||
public PullRequestEvent PullRequest { get; set; } | ||
|
||
public ScheduledEvent[] Schedule { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public ScheduledEvent[] Schedule { get; set; } | |
[YamlMember(DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public ScheduledEvent[] Schedule { get; set; } |
|
||
namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets | ||
{ | ||
public class EventsV2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation everywhere
|
||
namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets | ||
{ | ||
public class ScheduledEvent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation everywhere
|
||
public ScheduledEvent[] Schedule { get; set; } | ||
|
||
[YamlMember(Alias = "workflow_dispatch")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[YamlMember(Alias = "workflow_dispatch")] | |
[YamlMember(Alias = "workflow_dispatch", DefaultValuesHandling = DefaultValuesHandling.OmitDefaults))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove components already on other PR's
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | ||
public string Cron { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public string Cron { get; set; } | |
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public string Cron { get; set; } | |
[YamlMember(Order = 1, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public string Interval { get; set; } |
namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets | ||
{ | ||
public class WorkflowDispatchEvent | ||
{ } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incomplete, I was expecting properties
{ } | |
{ | |
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public WorkflowDispatchInput Environment { get; set; } | |
[YamlMember(Order = 1, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public WorkflowDispatchInput Version { get; set; } | |
[YamlMember(Order = 2, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)] | |
public WorkflowDispatchInput DryRun { get; set; } | |
} |
with
public class WorkflowDispatchInput
{
[YamlMember(Order = 0]
public string Description { get; set; }
[YamlMember(Order = 1]
public bool Required { get; set; }
[YamlMember(Order = 2]
public string Default { get; set; }
}
closes #143