Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DATA: EventsV2 #144

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mabroukmahdhi
Copy link
Contributor

closes #143

@mabroukmahdhi mabroukmahdhi self-assigned this Jan 24, 2025
@github-actions github-actions bot added the DATA For creating data models and migrations label Jan 24, 2025
[YamlMember(Alias = "pull_request", DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public PullRequestEvent PullRequest { get; set; }

public ScheduledEvent[] Schedule { get; set; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public ScheduledEvent[] Schedule { get; set; }
[YamlMember(DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public ScheduledEvent[] Schedule { get; set; }


namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets
{
public class EventsV2
Copy link
Collaborator

@cjdutoit cjdutoit Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation everywhere


namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets
{
public class ScheduledEvent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation everywhere


public ScheduledEvent[] Schedule { get; set; }

[YamlMember(Alias = "workflow_dispatch")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[YamlMember(Alias = "workflow_dispatch")]
[YamlMember(Alias = "workflow_dispatch", DefaultValuesHandling = DefaultValuesHandling.OmitDefaults))]

Copy link
Collaborator

@cjdutoit cjdutoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove components already on other PR's

Comment on lines +13 to +14
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public string Cron { get; set; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public string Cron { get; set; }
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public string Cron { get; set; }
[YamlMember(Order = 1, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public string Interval { get; set; }

namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets
{
public class WorkflowDispatchEvent
{ }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incomplete, I was expecting properties

Suggested change
{ }
{
[YamlMember(Order = 0, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public WorkflowDispatchInput Environment { get; set; }
[YamlMember(Order = 1, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public WorkflowDispatchInput Version { get; set; }
[YamlMember(Order = 2, DefaultValuesHandling = DefaultValuesHandling.OmitDefaults)]
public WorkflowDispatchInput DryRun { get; set; }
}

with

public class WorkflowDispatchInput
{
    [YamlMember(Order = 0]
    public string Description { get; set; }

    [YamlMember(Order = 1]
    public bool Required { get; set; }

    [YamlMember(Order = 2]
    public string Default { get; set; }
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DATA For creating data models and migrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA: EventsV2
2 participants