-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
48 mitigator summary #58
Conversation
…age tables, updates the heatmaps panel with tooltip guidance.
… mitigator and scheme coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for enacting what was a fairly vague request!
Re the 'Mitigator coverage' table: don't worry about this now, but we may want to include a mitigator code column and maybe some other filterable/sortable columns like the mitigator type (i.e. 'activity avoidance' or 'efficiencies'), but I think this is a bigger question that's actually part of #43. And the mitigator lookup in the 'Data' section is always there if people want more info.
Re the 'Scheme coverage' table: your idea to embolden the selected schemes is a nice touch. There's still part of me that wonders if we should automatically filter these coverage tables to the schemes selected in global settings. But I think this is the right place to start.
I've added a couple of comments and suggestions below; could you make a couple of adjustments and I'll re-review?
make_mitigator_uptake_dt <- function(dat, selected_schemes) { | ||
|
||
dat |> | ||
# remove ampersand from mitigator names - causes issues with DT filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious! Added issue #60. Ultimately we probably want to maintain the ampersands, if possible.
Close #48
Includes:
Both views show comparisons between all (schemes/mitigators) and selected(schemes/mitigators).