Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

48 mitigator summary #58

Merged
merged 5 commits into from
Oct 4, 2024
Merged

48 mitigator summary #58

merged 5 commits into from
Oct 4, 2024

Conversation

craig-parylo
Copy link
Contributor

Close #48

Includes:

  • additional tabs under the 'Heatmaps' section for mitigator coverage and scheme coverage
  • adds tooltips to sub-tabs to explain roles of each tab
  • adds server code to populate the two new tabs with views for mitigaor coverage and scheme coverage
  • adds functions to process the data and render the DT objects
  • adds documentation for the new functions

Both views show comparisons between all (schemes/mitigators) and selected(schemes/mitigators).

Copy link
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for enacting what was a fairly vague request!

Re the 'Mitigator coverage' table: don't worry about this now, but we may want to include a mitigator code column and maybe some other filterable/sortable columns like the mitigator type (i.e. 'activity avoidance' or 'efficiencies'), but I think this is a bigger question that's actually part of #43. And the mitigator lookup in the 'Data' section is always there if people want more info.

Re the 'Scheme coverage' table: your idea to embolden the selected schemes is a nice touch. There's still part of me that wonders if we should automatically filter these coverage tables to the schemes selected in global settings. But I think this is the right place to start.

I've added a couple of comments and suggestions below; could you make a couple of adjustments and I'll re-review?

make_mitigator_uptake_dt <- function(dat, selected_schemes) {

dat |>
# remove ampersand from mitigator names - causes issues with DT filters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious! Added issue #60. Ultimately we probably want to maintain the ampersands, if possible.

@craig-parylo craig-parylo requested a review from matt-dray October 4, 2024 07:45
@craig-parylo craig-parylo merged commit f835dbf into main Oct 4, 2024
@craig-parylo craig-parylo deleted the 48_mitigator_summary branch October 4, 2024 11:31
@matt-dray matt-dray added this to the v0.3.0 milestone Nov 11, 2024
@matt-dray matt-dray added enhancement New feature or request must MoSCoW priority labels Nov 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request must MoSCoW priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate the percentage of schemes choosing a mitigator and mitigators selected by a scheme
2 participants