-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
49 heatmap mitigator name v2 #64
Conversation
…lot heatmap plot as well as observers to calculate size of the plot and an updated call to plot with the height argument
… names on the x-axis based on how many are to be shown
…ames or codes in the heatmap
…er to track mitigators when toggling names on / off in the heatmap plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you for this! These are well thought-out features.
Your dynamic scheme-name labelling solution is a great compromise. I've added a small techdebt issue in #66 to worry about later.
I've also added #65 for us to think about consistency of presentation. I think percentage is the more intuitive choice, as you've used here.
One small thing before approval: can you add a title for the heatmap legend (perhaps my fault for not including one in the first place!)? '80% Prediction Interval' like in the pointrange plot, but we may need to be more descriptive when #10 is completed.
Happy to chat more about these.
… as requested in PR review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #49
Changes:
x-axis optimisation:
y-axis optimisation: