Skip to content

chore: fail url_check when broken links are found #241

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore: fail url_check when broken links are found #241

merged 3 commits into from
Apr 10, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 9, 2024 •
edited
Loading

Description

Related to #154.

Having

merged will allow to make the url_check truly detect broken links. This PR reverts cd0f441 in #231.

Clearly, please rebase before merging.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing checks pass.
  • No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
  • If it's a new explanation, it contains solid, understandable, and accessible information.
  • I have read the whole contributing guidelines and agree to the Code of Conduct.

@vil02 vil02 marked this pull request as ready for review April 9, 2024 19:43
appgurueu
appgurueu approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@appgurueu appgurueu merged commit bbfce50 into TheAlgorithms:master Apr 10, 2024
3 checks passed
@vil02 vil02 deleted the fail_when_broken_links_found branch April 10, 2024 21:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@vbrazo vbrazo Awaiting requested review from vbrazo vbrazo is a code owner

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @appgurueu