Skip to content

fix: #898 Awesome workflow (1 files are not in one and only one directory) #900

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2021
Merged

fix: #898 Awesome workflow (1 files are not in one and only one directory) #900

merged 6 commits into from
Oct 25, 2021

Conversation

straight-into-the-wall
Copy link
Contributor

@straight-into-the-wall straight-into-the-wall commented Oct 25, 2021 •
edited by gitpod-io bot
Loading

Description of Change

Awesome workflow was counting the length of the modified file list in the number of undesired files.

Added a variable that subtract the right value of one to the length of the modified files.

References

#898

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • test must pass
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Not a phython expert here so ... double check the implementation.

This was referenced Oct 25, 2021
Closed
Merged
Panquesito7
Panquesito7 reviewed Oct 25, 2021
View reviewed changes
leetcode/src/1.c Outdated
@@ -1,17 +1,168 @@
int *twoSum(int *nums, int numsSize, int target, int *returnSize)
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this file in a separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done one mistake I never do. making a PR from master, now all the following branches I create from master have that file (1.c) too. D'HO!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem should be solved now. For instance I closed the first of my PR the 1.c one and reopen a new one. I also reverted my master branch in order to avoid other mistakes.

@Panquesito7 Panquesito7 linked an issue Oct 25, 2021 that may be closed by this pull request
Awesome CI Workflow Code formater: "2 files are not in one and only one directory" but they are in separate branches. #898
Closed
Panquesito7
Panquesito7 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 added approved Approved; waiting for merge enhancement New feature or request labels Oct 25, 2021
@straight-into-the-wall straight-into-the-wall mentioned this pull request Oct 25, 2021
Open
6 tasks
@Panquesito7 Panquesito7 merged commit 779e2f0 into TheAlgorithms:master Oct 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mishraabhinn mishraabhinn mishraabhinn approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@aminoxix aminoxix Awaiting requested review from aminoxix

@ayaankhan98 ayaankhan98 Awaiting requested review from ayaankhan98

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@straight-into-the-wall @mishraabhinn @Panquesito7