Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Simplify diffie_hellman.py #12541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Simplify diffie_hellman.py #12541

wants to merge 3 commits into from
+37 −66

Conversation

isidroas
Copy link
Contributor

@isidroas isidroas commented Jan 25, 2025 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@isidroas
simplified and refactor diffie_hellman.py
a65b346 
Everything is a refactor except the method generate_shared_key().
Its hashing final step has been removed for simplicity
@isidroas
Refactor doctest; change initializer arguments
bb987c4 
group: int -> prime: int, generator: int
@isidroas isidroas changed the title Dh Simplify diffie_hellman.py Jan 25, 2025
@isidroas isidroas marked this pull request as draft January 25, 2025 12:51
@isidroas
Copy link
Contributor Author

These are many unrelated changes. Let me know if I have to divide them into commits or PRs.

@isidroas isidroas marked this pull request as ready for review January 25, 2025 12:56
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Jan 25, 2025
@isidroas
Copy link
Contributor Author

The git history shows that the author is @ruppysuppy . Do these changes seem good to you?

Everything is a refactor except the method generate_shared_key(): its hashing final step has been removed for simplicity and because the key derivation is a separate problem.

ruppysuppy
ruppysuppy reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isidroas I am happy with the changes, but slightly unsure about this - my thoughts related to cryptography is a bit rusty (hadn't touched the topic in a while), so a brief explanation would be great

ciphers/diffie_hellman.py
Comment on lines +194 to +195
Both parties should agree on the same public parameters
>>> bob = DiffieHellman(alice.prime, alice.generator)
Copy link
Member

@ruppysuppy ruppysuppy Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we generating Bob's data using Alice's prime? Isn't the prime supposed to be private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only secret attribute is each self.__private_key, which does not necessarily have to be a prime number. In cryptography it is strange that more than one parameter must be kept secret.

@isidroas
Copy link
Contributor Author

Thank you for the feedback @ruppysuppy ! I added a bit of documentation in 93c7ac0

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isidroas @ruppysuppy