Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolved log(0) error in KL divergence Issue#12233 #12556

Closed
wants to merge 2 commits into from

Conversation

anscian
Copy link

@anscian anscian commented Feb 4, 2025

Describe your change:

Fixes #12233
Removed log(0) error from kullback_leibler_divergence in machine_learning/loss_functions.py by filtering out zeroed entries from both y_true and y_pred.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Feb 4, 2025
@anscian anscian closed this Feb 4, 2025
@anscian anscian deleted the kl branch February 4, 2025 01:49
@anscian anscian restored the kl branch February 4, 2025 01:50
@anscian anscian reopened this Feb 4, 2025
@algorithms-keeper algorithms-keeper bot added the enhancement This PR modified some existing files label Feb 4, 2025
@anscian anscian closed this Feb 4, 2025
@anscian
Copy link
Author

anscian commented Feb 4, 2025

ruff fails, redoing it to comply with ruff

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid log(0) in KL divergence
1 participant