Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Addition of multiple_longest_common_subsequence #861

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Gaspardcode
Copy link

Description

To whom it may concern,

this pull request aims at introducing an algorithm to find the longest common subsequence among multiple sequences.

Finding a solution other than brute force is not really intuitive. I advise to look at the first comments of this thread.

The pull request implements a method based on heuristic, as described in the following research paper.

Thank you for considering this work.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
    Note: I mean I did only delete the issues related to my pull request
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 99.53052% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.53%. Comparing base (b4aecf4) to head (b355c68).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/string/multiple_longest_common_subsequence.rs 99.53% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage   95.49%   95.53%   +0.04%     
==========================================
  Files         316      318       +2     
  Lines       22919    23161     +242     
==========================================
+ Hits        21887    22128     +241     
- Misses       1032     1033       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gaspardcode
Copy link
Author

Hello,

I might need help with this pull request, especially cargo clippy --all -- -D warnings.

Surely I am not supposed to fix the 500+ errors already present before, right ?
I tried to run cargo clippy --fix but it wouldn't do.

Thank you

@Gaspardcode
Copy link
Author

image

@vil02
Copy link
Member

vil02 commented Mar 19, 2025

Hello,

I might need help with this pull request, especially cargo clippy --all -- -D warnings.

Surely I am not supposed to fix the 500+ errors already present before, right ? I tried to run cargo clippy --fix but it wouldn't do.

Thank you

@Gaspardcode: Try updating your branch. There were some new warnings introduced, but it should work now (cf. #871).

@Gaspardcode
Copy link
Author

Hello,
I might need help with this pull request, especially cargo clippy --all -- -D warnings.
Surely I am not supposed to fix the 500+ errors already present before, right ? I tried to run cargo clippy --fix but it wouldn't do.
Thank you

@Gaspardcode: Try updating your branch. There were some new warnings introduced, but it should work now (cf. #871).

Hello, I did indeed fixed it by simply pulling, thank you

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants